chore: migrate rust/qrcode to icp-cli#1401
Draft
marc0olo wants to merge 2 commits into
Draft
Conversation
marc0olo
force-pushed
the
chore/migrate-rust-qrcode-to-icp-cli
branch
from
f082aa2 to
64f5730
Compare
Replaces dfx.json with icp.yaml using @dfinity/rust@v3.3.0 and @dfinity/asset-canister@v2.2.1 recipes. Moves Rust source to backend/, rewrites frontend to Vite + @icp-sdk/bindgen, updates Makefile tests to use icp canister call, adds CI workflow, and removes dfx artifacts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marc0olo
force-pushed
the
chore/migrate-rust-qrcode-to-icp-cli
branch
from
64f5730 to
305d50b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0(backend) and@dfinity/asset-canister@v2.2.1(frontend)src/qrcode_backend/tobackend/and renames package tobackend@icp-sdk/bindgen, updating actor wiring to usesafeGetCanisterEnv/ic_envcookie patternicp canister call(6--querycalls + 1 update call), removes dfx/deploy dependency.github/workflows/qrcode.ymlCI job forrust-qrcodeusingghcr.io/dfinity/icp-dev-env-rust:1.0.0dfx.json,BUILD.md,webpack.config.js, per-example.devcontainer/, and oldsrc/directoryTest plan
icp network start -d && icp deploy && make testinrust/qrcode🤖 Generated with Claude Code